fix(cli): ignore msbuild binlog files #14621
Merged
+27
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankcalise
changed the title
|
/azp run PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes an issue by updating the CLI logic to properly ignore MSBuild log files and adjusts the default log directory for build logs. Key changes include:
- Updating the gitignore templates in both cpp-lib and cpp-app to ignore MSBuild binlog, error, and warning files.
- Modifying the msbuildtools.ts file to change the default log directory from the OS temporary directory to the directory of the solution file and simplifying the binlog flag.
- Updating change files with prerelease metadata for both the library and CLI.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| vnext/templates/cpp-lib/windows/_gitignore | Added rules to ignore MSBuild log files; note a spelling error in a comment. |
| vnext/templates/cpp-app/windows/_gitignore | Added rules to ignore MSBuild log files; note a spelling error in a comment. |
| packages/@react-native-windows/cli/src/utils/msbuildtools.ts | Updated default log directory and simplified binlog option handling. |
| change/*.json | Updated prerelease metadata entries. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
anupriya13
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Why
What is the motivation for this change? Add a few sentences describing the context and overall goals of the pull request's commits.
Resolves #14160
What
.gitignoretemplates to target MS Build related log files (*.binlog, *.wrn, *.err)windowsdirectory (determined from the location of the solution file)Screenshots
TODO
Testing
TODO
Changelog
Should this change be included in the release notes: No
Microsoft Reviewers: Open in CodeFlow